turbopack_ecmascript/

parse.rs

use std::sync::Arc;

use anyhow::{Context, Result};
use async_trait::async_trait;
use bytes_str::BytesStr;
use rustc_hash::{FxHashMap, FxHashSet};
use swc_core::{
    atoms::Atom,
    base::SwcComments,
    common::{
        BytePos, FileName, GLOBALS, Globals, LineCol, Mark, SyntaxContext,
        errors::{HANDLER, Handler},
        input::StringInput,
        source_map::{Files, SourceMapGenConfig, build_source_map},
    },
    ecma::{
        ast::{
            EsVersion, Id, Ident, IdentName, ObjectPatProp, Pat, Program, TsModuleDecl,
            TsModuleName, VarDecl,
        },
        lints::{self, config::LintConfig, rules::LintParams},
        parser::{EsSyntax, Parser, Syntax, TsSyntax, lexer::Lexer},
        transforms::{
            base::{
                helpers::{HELPERS, Helpers},
                resolver,
            },
            proposal::explicit_resource_management::explicit_resource_management,
        },
        visit::{Visit, VisitMutWith, VisitWith, noop_visit_type},
    },
};
use tracing::{Instrument, instrument};
use turbo_rcstr::{RcStr, rcstr};
use turbo_tasks::{PrettyPrintError, ResolvedVc, ValueToString, Vc, turbofmt, util::WrapFuture};
use turbo_tasks_fs::{FileContent, FileSystemPath, rope::Rope};
use turbo_tasks_hash::hash_xxh3_hash64;
use turbopack_core::{
    SOURCE_URL_PROTOCOL,
    asset::{Asset, AssetContent},
    issue::{Issue, IssueExt, IssueSeverity, IssueSource, IssueStage, StyledString},
    source::Source,
    source_map::utils::add_default_ignore_list,
};
use turbopack_swc_utils::emitter::IssueEmitter;

use super::EcmascriptModuleAssetType;
use crate::{
    EcmascriptInputTransform,
    analyzer::graph::EvalContext,
    magic_identifier,
    swc_comments::ImmutableComments,
    transform::{EcmascriptInputTransforms, TransformContext},
};

/// Collects identifier names and their byte positions from an AST.
/// This is used to populate the `names` field in source maps.
/// Based on swc_compiler_base::IdentCollector.
pub struct IdentCollector {
    names_vec: Vec<(BytePos, Atom)>,
    /// Stack of current class names for mapping constructors to class names
    class_stack: Vec<Atom>,
}

impl IdentCollector {
    /// Converts the collected identifiers into a map keyed by the start position of the identifier
    pub fn into_map(self) -> FxHashMap<BytePos, Atom> {
        FxHashMap::from_iter(self.names_vec)
    }
}
impl Default for IdentCollector {
    fn default() -> Self {
        Self {
            names_vec: Vec::with_capacity(128),
            class_stack: Vec::new(),
        }
    }
}

/// Unmangles a Turbopack magic identifier, returning the original name or the input if not mangled
fn unmangle_atom(name: &Atom) -> Atom {
    magic_identifier::unmangle(name)
        .map(Atom::from)
        .unwrap_or_else(|| name.clone())
}

impl Visit for IdentCollector {
    noop_visit_type!();

    fn visit_ident(&mut self, ident: &Ident) {
        // Skip dummy spans - these are synthetic/generated identifiers
        if !ident.span.lo.is_dummy() {
            // we can get away with just the `lo` positions since identifiers cannot overlap.
            self.names_vec
                .push((ident.span.lo, unmangle_atom(&ident.sym)));
        }
    }

    fn visit_ident_name(&mut self, ident: &IdentName) {
        if ident.span.lo.is_dummy() {
            return;
        }

        // Map constructor names to the class name
        let mut sym = &ident.sym;
        if ident.sym == "constructor" {
            if let Some(class_name) = self.class_stack.last() {
                sym = class_name;
            } else {
                // If no class name in stack, skip the constructor mapping
                return;
            }
        }

        self.names_vec.push((ident.span.lo, unmangle_atom(sym)));
    }

    fn visit_class_decl(&mut self, decl: &swc_core::ecma::ast::ClassDecl) {
        // Push class name onto stack
        self.class_stack.push(decl.ident.sym.clone());

        // Visit the identifier and class
        self.visit_ident(&decl.ident);
        self.visit_class(&decl.class);

        // Pop class name from stack
        self.class_stack.pop();
    }

    fn visit_class_expr(&mut self, expr: &swc_core::ecma::ast::ClassExpr) {
        // Push class name onto stack if it exists
        if let Some(ref ident) = expr.ident {
            self.class_stack.push(ident.sym.clone());
            self.visit_ident(ident);
        }

        // Visit the class body
        self.visit_class(&expr.class);

        // Pop class name from stack if it was pushed
        if expr.ident.is_some() {
            self.class_stack.pop();
        }
    }
}

#[turbo_tasks::value(shared, serialization = "skip", eq = "manual", cell = "new")]
#[allow(clippy::large_enum_variant)]
pub enum ParseResult {
    Ok {
        #[turbo_tasks(debug_ignore, trace_ignore)]
        program: Program,
        #[turbo_tasks(debug_ignore, trace_ignore)]
        comments: Arc<ImmutableComments>,
        #[turbo_tasks(debug_ignore, trace_ignore)]
        eval_context: EvalContext,
        #[turbo_tasks(debug_ignore, trace_ignore)]
        globals: Arc<Globals>,
        #[turbo_tasks(debug_ignore, trace_ignore)]
        source_map: Arc<swc_core::common::SourceMap>,
        source_mapping_url: Option<RcStr>,
        /// Raw bytes of the source that produced this parse, captured atomically
        /// with the AST. `failsafe_parse` uses this to recover good parses in development on
        /// error.
        #[turbo_tasks(debug_ignore, trace_ignore)]
        program_source: Rope,
    },
    Unparsable {
        messages: Option<Vec<RcStr>>,
    },
    NotFound,
}

/// `original_source_maps_complete` indicates whether the `original_source_maps` cover the whole
/// map, i.e. whether every module that ended up in `mappings` had an original sourcemap.
#[instrument(level = "info", name = "generate source map", skip_all)]
pub fn generate_js_source_map<'a>(
    files_map: &impl Files,
    mappings: Vec<(BytePos, LineCol)>,
    original_source_maps: impl IntoIterator<Item = &'a Rope>,
    original_source_maps_complete: bool,
    inline_sources_content: bool,
    names: FxHashMap<BytePos, Atom>,
) -> Result<Rope> {
    let original_source_maps = original_source_maps
        .into_iter()
        .map(|map| map.to_bytes())
        .collect::<Vec<_>>();
    let original_source_maps = original_source_maps
        .iter()
        .map(|map| Ok(swc_sourcemap::lazy::decode(map)?.into_source_map()?))
        .collect::<Result<Vec<_>>>()?;

    let fast_path_single_original_source_map =
        original_source_maps.len() == 1 && original_source_maps_complete;

    let mut new_mappings = build_source_map(
        files_map,
        &mappings,
        None,
        &InlineSourcesContentConfig {
            // If we are going to adjust the source map, we are going to throw the source contents
            // of this source map away regardless.
            //
            // In other words, we don't need the content of `B` in source map chain of A -> B -> C.
            // We only need the source content of `A`, and a way to map the content of `B` back to
            // `A`, while constructing the final source map, `C`.
            inline_sources_content: inline_sources_content && !fast_path_single_original_source_map,
            names,
        },
    );

    if original_source_maps.is_empty() {
        // We don't convert sourcemap::SourceMap into raw_sourcemap::SourceMap because we don't
        // need to adjust mappings

        add_default_ignore_list(&mut new_mappings);

        let mut result = vec![];
        new_mappings.to_writer(&mut result)?;
        Ok(Rope::from(result))
    } else if fast_path_single_original_source_map {
        let mut map = original_source_maps.into_iter().next().unwrap();
        // TODO: Make this more efficient
        map.adjust_mappings(new_mappings);

        // TODO: Enable this when we have a way to handle the ignore list
        // add_default_ignore_list(&mut map);
        let map = map.into_raw_sourcemap();
        let result = serde_json::to_vec(&map)?;
        Ok(Rope::from(result))
    } else {
        let mut map = new_mappings.adjust_mappings_from_multiple(original_source_maps);

        add_default_ignore_list(&mut map);

        let mut result = vec![];
        map.to_writer(&mut result)?;
        Ok(Rope::from(result))
    }
}

/// A config to generate a source map which includes the source content of every
/// source file. SWC doesn't inline sources content by default when generating a
/// sourcemap, so we need to provide a custom config to do it.
pub struct InlineSourcesContentConfig {
    inline_sources_content: bool,
    names: FxHashMap<BytePos, Atom>,
}

impl SourceMapGenConfig for InlineSourcesContentConfig {
    fn file_name_to_source(&self, f: &FileName) -> String {
        match f {
            FileName::Custom(s) => {
                format!("{SOURCE_URL_PROTOCOL}///{s}")
            }
            _ => f.to_string(),
        }
    }

    fn inline_sources_content(&self, _f: &FileName) -> bool {
        self.inline_sources_content
    }

    fn name_for_bytepos(&self, pos: BytePos) -> Option<&str> {
        self.names.get(&pos).map(|v| &**v)
    }
}

#[turbo_tasks::function]
pub async fn parse(
    source: ResolvedVc<Box<dyn Source>>,
    ty: EcmascriptModuleAssetType,
    transforms: ResolvedVc<EcmascriptInputTransforms>,
    node_env: RcStr,
    is_external_tracing: bool,
    inline_helpers: bool,
) -> Result<Vc<ParseResult>> {
    let span = tracing::info_span!(
        "parse ecmascript",
        name = display(source.ident().to_string().await?),
        ty = display(&ty)
    );

    match parse_internal(
        source,
        ty,
        transforms,
        node_env,
        is_external_tracing,
        inline_helpers,
    )
    .instrument(span)
    .await
    {
        Ok(result) => Ok(result),
        // ast-grep-ignore: no-context-turbofmt
        Err(error) => Err(error.context(turbofmt!("failed to parse {}", source.ident()).await?)),
    }
}

async fn parse_internal(
    source: ResolvedVc<Box<dyn Source>>,
    ty: EcmascriptModuleAssetType,
    transforms: ResolvedVc<EcmascriptInputTransforms>,
    node_env: RcStr,
    loose_errors: bool,
    inline_helpers: bool,
) -> Result<Vc<ParseResult>> {
    let content = source.content();
    let source_ident = source.ident().await?;
    let fs_path = &source_ident.path;
    let ident = &*source.ident().to_string().await?;
    let file_path_hash = hash_xxh3_hash64(ident) as u128;
    let content = match content.await {
        Ok(content) => content,
        Err(error) => {
            let error: RcStr = PrettyPrintError(&error).to_string().into();
            ReadSourceIssue {
                source: IssueSource::from_source_only(source),
                error: error.clone(),
                severity: if loose_errors {
                    IssueSeverity::Warning
                } else {
                    IssueSeverity::Error
                },
            }
            .resolved_cell()
            .emit();

            return Ok(ParseResult::Unparsable {
                messages: Some(vec![error]),
            }
            .cell());
        }
    };
    Ok(match &*content {
        AssetContent::File(file) => match &*file.await? {
            FileContent::NotFound => ParseResult::NotFound.cell(),
            FileContent::Content(file) => {
                let transforms = &*transforms.await?;
                match parse_file_content(
                    file.content().clone(),
                    fs_path,
                    ident,
                    source_ident.query.clone(),
                    file_path_hash,
                    source,
                    ty,
                    transforms,
                    node_env.clone(),
                    loose_errors,
                    inline_helpers,
                )
                .await
                {
                    Ok(result) => result,
                    Err(e) => {
                        // ast-grep-ignore: no-context-turbofmt
                        return Err(e).context(
                            turbofmt!("Transforming and/or parsing of {} failed", source.ident())
                                .await?,
                        );
                    }
                }
            }
        },
        AssetContent::Redirect { .. } => ParseResult::Unparsable { messages: None }.cell(),
    })
}

async fn parse_file_content(
    program_source: Rope,
    fs_path: &FileSystemPath,
    ident: &str,
    query: RcStr,
    file_path_hash: u128,
    source: ResolvedVc<Box<dyn Source>>,
    ty: EcmascriptModuleAssetType,
    transforms: &[EcmascriptInputTransform],
    node_env: RcStr,
    loose_errors: bool,
    inline_helpers: bool,
) -> Result<Vc<ParseResult>> {
    let string = match BytesStr::from_utf8(program_source.clone().into_bytes()) {
        Ok(s) => s,
        Err(error) => {
            let error: RcStr = PrettyPrintError(
                &anyhow::anyhow!(error).context("failed to convert rope into string"),
            )
            .to_string()
            .into();
            ReadSourceIssue {
                // Technically we could supply byte offsets to the issue source, but
                // that would cause another utf8 error to be produced when we
                // attempt to infer line/column
                // offsets
                source: IssueSource::from_source_only(source),
                error: error.clone(),
                severity: if loose_errors {
                    IssueSeverity::Warning
                } else {
                    IssueSeverity::Error
                },
            }
            .resolved_cell()
            .emit();
            return Ok(ParseResult::Unparsable {
                messages: Some(vec![error]),
            }
            .cell());
        }
    };
    let source_map: Arc<swc_core::common::SourceMap> = Default::default();
    let (emitter, collector) = IssueEmitter::new(
        source,
        source_map.clone(),
        Some(rcstr!("Ecmascript file had an error")),
    );
    let handler = Handler::with_emitter(true, false, Box::new(emitter));

    let (emitter, collector_parse) = IssueEmitter::new(
        source,
        source_map.clone(),
        Some(rcstr!("Parsing ecmascript source code failed")),
    );
    let parser_handler = Handler::with_emitter(true, false, Box::new(emitter));
    let globals = Arc::new(Globals::new());
    let globals_ref = &globals;

    let mut result = WrapFuture::new(
        async {
            let file_name = FileName::Custom(ident.to_string());
            let fm = source_map.new_source_file(file_name.clone().into(), string);

            let comments = SwcComments::default();

            let mut parsed_program = {
                let lexer = Lexer::new(
                    match ty {
                        EcmascriptModuleAssetType::Ecmascript
                        | EcmascriptModuleAssetType::EcmascriptExtensionless => {
                            Syntax::Es(EsSyntax {
                                jsx: true,
                                fn_bind: true,
                                decorators: true,
                                decorators_before_export: true,
                                export_default_from: true,
                                import_attributes: true,
                                allow_super_outside_method: true,
                                allow_return_outside_function: true,
                                auto_accessors: true,
                                explicit_resource_management: true,
                            })
                        }
                        EcmascriptModuleAssetType::Typescript { tsx, .. } => {
                            Syntax::Typescript(TsSyntax {
                                decorators: true,
                                dts: false,
                                tsx,
                                ..Default::default()
                            })
                        }
                        EcmascriptModuleAssetType::TypescriptDeclaration => {
                            Syntax::Typescript(TsSyntax {
                                decorators: true,
                                dts: true,
                                tsx: false,
                                ..Default::default()
                            })
                        }
                    },
                    EsVersion::latest(),
                    StringInput::from(&*fm),
                    Some(&comments),
                );

                let mut parser = Parser::new_from(lexer);
                let span = tracing::trace_span!("swc_parse").entered();
                let program_result = parser.parse_program();
                drop(span);

                let mut has_errors = vec![];
                for e in parser.take_errors() {
                    let mut e = e.into_diagnostic(&parser_handler);
                    has_errors.extend(e.message.iter().map(|m| m.0.as_str().into()));
                    e.emit();
                }

                if !has_errors.is_empty() {
                    return Ok(ParseResult::Unparsable {
                        messages: Some(has_errors),
                    });
                }

                match program_result {
                    Ok(parsed_program) => parsed_program,
                    Err(e) => {
                        let mut e = e.into_diagnostic(&parser_handler);
                        let messages = e.message.iter().map(|m| m.0.as_str().into()).collect();

                        e.emit();

                        return Ok(ParseResult::Unparsable {
                            messages: Some(messages),
                        });
                    }
                }
            };

            let unresolved_mark = Mark::new();
            let top_level_mark = Mark::new();

            let is_typescript = matches!(
                ty,
                EcmascriptModuleAssetType::Typescript { .. }
                    | EcmascriptModuleAssetType::TypescriptDeclaration
            );

            let helpers = Helpers::new(!inline_helpers);
            let span = tracing::trace_span!("swc_resolver").entered();

            parsed_program.visit_mut_with(&mut resolver(
                unresolved_mark,
                top_level_mark,
                is_typescript,
            ));
            drop(span);

            let span = tracing::trace_span!("swc_lint").entered();

            let lint_config = LintConfig::default();
            let rules = lints::rules::all(LintParams {
                program: &parsed_program,
                lint_config: &lint_config,
                unresolved_ctxt: SyntaxContext::empty().apply_mark(unresolved_mark),
                top_level_ctxt: SyntaxContext::empty().apply_mark(top_level_mark),
                es_version: EsVersion::latest(),
                source_map: source_map.clone(),
            });

            parsed_program.mutate(lints::rules::lint_pass(rules));
            drop(span);

            HELPERS.set(&helpers, || {
                parsed_program.mutate(explicit_resource_management());
            });

            let var_with_ts_declare = if is_typescript {
                VarDeclWithTsDeclareCollector::collect(&parsed_program)
            } else {
                FxHashSet::default()
            };

            let mut helpers = helpers.data();
            let transform_context = TransformContext {
                comments: &comments,
                source_map: &source_map,
                top_level_mark,
                unresolved_mark,
                file_path_str: &fs_path.path,
                file_name_str: fs_path.file_name(),
                file_name_hash: file_path_hash,
                query_str: query,
                file_path: fs_path.clone(),
                source,
                source_text: &fm.src,
                node_env,
            };
            let span = tracing::trace_span!("transforms");
            async {
                for transform in transforms.iter() {
                    helpers = transform
                        .apply(&mut parsed_program, &transform_context, helpers)
                        .await?;
                }
                anyhow::Ok(())
            }
            .instrument(span)
            .await?;

            if parser_handler.has_errors() {
                let messages = if let Some(error) = collector_parse.last_emitted_issue() {
                    // The emitter created in here only uses StyledString::Text
                    if let StyledString::Text(xx) = &*error.await?.message.await? {
                        Some(vec![xx.clone()])
                    } else {
                        None
                    }
                } else {
                    None
                };
                let messages = Some(messages.unwrap_or_else(|| vec![fm.src.clone().into()]));
                return Ok(ParseResult::Unparsable { messages });
            }

            let helpers = Helpers::from_data(helpers);
            HELPERS.set(&helpers, || {
                parsed_program.mutate(swc_core::ecma::transforms::base::helpers::inject_helpers(
                    unresolved_mark,
                ));
            });

            let eval_context = EvalContext::new(
                Some(&parsed_program),
                unresolved_mark,
                top_level_mark,
                Arc::new(var_with_ts_declare),
                Some(&comments),
            );

            let (comments, source_mapping_url) =
                ImmutableComments::new_with_source_mapping_url(comments);

            Ok::<ParseResult, anyhow::Error>(ParseResult::Ok {
                program: parsed_program,
                comments: Arc::new(comments),
                eval_context,
                // Temporary globals as the current one can't be moved yet, since they are
                // borrowed
                globals: Arc::new(Globals::new()),
                source_map,
                source_mapping_url: source_mapping_url.map(|s| s.into()),
                program_source,
            })
        },
        |f, cx| GLOBALS.set(globals_ref, || HANDLER.set(&handler, || f.poll(cx))),
    )
    .await?;
    if let ParseResult::Ok {
        globals: ref mut g, ..
    } = result
    {
        // Assign the correct globals
        *g = globals;
    }
    collector.emit(loose_errors).await?;
    collector_parse.emit(loose_errors).await?;
    Ok(result.cell())
}

#[turbo_tasks::value]
struct ReadSourceIssue {
    source: IssueSource,
    error: RcStr,
    severity: IssueSeverity,
}

#[async_trait]
#[turbo_tasks::value_impl]
impl Issue for ReadSourceIssue {
    async fn file_path(&self) -> Result<FileSystemPath> {
        self.source.file_path().await
    }

    async fn title(&self) -> Result<StyledString> {
        Ok(StyledString::Text(rcstr!(
            "Reading source code for parsing failed"
        )))
    }

    async fn description(&self) -> Result<Option<StyledString>> {
        Ok(Some(StyledString::Text(
            format!(
                "An unexpected error happened while trying to read the source code to parse: {}",
                self.error
            )
            .into(),
        )))
    }

    fn severity(&self) -> IssueSeverity {
        self.severity
    }

    fn stage(&self) -> IssueStage {
        IssueStage::Load
    }

    fn source(&self) -> Option<IssueSource> {
        Some(self.source)
    }
}

struct VarDeclWithTsDeclareCollector {
    id_with_no_ts_declare: FxHashSet<Id>,
    id_with_ts_declare: FxHashSet<Id>,
}

impl VarDeclWithTsDeclareCollector {
    fn collect<N: VisitWith<VarDeclWithTsDeclareCollector>>(n: &N) -> FxHashSet<Id> {
        let mut collector = VarDeclWithTsDeclareCollector {
            id_with_no_ts_declare: Default::default(),
            id_with_ts_declare: Default::default(),
        };
        n.visit_with(&mut collector);
        collector
            .id_with_ts_declare
            .retain(|id| !collector.id_with_no_ts_declare.contains(id));
        collector.id_with_ts_declare
    }

    fn handle_pat(&mut self, pat: &Pat, declare: bool) {
        match pat {
            Pat::Ident(binding_ident) => {
                if declare {
                    self.id_with_ts_declare.insert(binding_ident.to_id());
                } else {
                    self.id_with_no_ts_declare.insert(binding_ident.to_id());
                }
            }
            Pat::Array(array_pat) => {
                for pat in array_pat.elems.iter().flatten() {
                    self.handle_pat(pat, declare);
                }
            }
            Pat::Object(object_pat) => {
                for prop in object_pat.props.iter() {
                    match prop {
                        ObjectPatProp::KeyValue(key_value_pat_prop) => {
                            self.handle_pat(&key_value_pat_prop.value, declare);
                        }
                        ObjectPatProp::Assign(assign_pat_prop) => {
                            if declare {
                                self.id_with_ts_declare.insert(assign_pat_prop.key.to_id());
                            } else {
                                self.id_with_no_ts_declare
                                    .insert(assign_pat_prop.key.to_id());
                            }
                        }
                        _ => {}
                    }
                }
            }
            _ => {}
        }
    }
}

impl Visit for VarDeclWithTsDeclareCollector {
    noop_visit_type!();

    fn visit_var_decl(&mut self, node: &VarDecl) {
        for decl in node.decls.iter() {
            self.handle_pat(&decl.name, node.declare);
        }
    }

    fn visit_ts_module_decl(&mut self, node: &TsModuleDecl) {
        if node.declare
            && let TsModuleName::Ident(id) = &node.id
        {
            self.id_with_ts_declare.insert(id.to_id());
        }
    }
}

/// Re-parses a module directly from saved bytes, bypassing `source.content()`.
///
/// Used by `failsafe_parse` to serve the last good AST when the live file has a syntax error.
pub async fn parse_from_rope(
    rope: Rope,
    source: ResolvedVc<Box<dyn Source>>,
    ty: EcmascriptModuleAssetType,
    transforms: ResolvedVc<EcmascriptInputTransforms>,
    node_env: RcStr,
) -> Result<Vc<ParseResult>> {
    let ident_vc = source.ident();
    let ident_ref = ident_vc.await?;
    let ident = &*ident_vc.to_string().await?;
    let file_path_hash = hash_xxh3_hash64(ident) as u128;
    let query = ident_ref.query.clone();
    let transforms = &*transforms.await?;
    parse_file_content(
        rope,
        &ident_ref.path,
        ident,
        query,
        file_path_hash,
        source,
        ty,
        transforms,
        node_env,
        false,
        false,
    )
    .await
}

#[cfg(test)]
mod tests {
    use swc_core::{
        common::{FileName, GLOBALS, SourceMap, sync::Lrc},
        ecma::parser::{Parser, Syntax, TsSyntax, lexer::Lexer},
    };

    use super::VarDeclWithTsDeclareCollector;

    fn parse_and_collect(code: &str) -> Vec<String> {
        GLOBALS.set(&Default::default(), || {
            let cm: Lrc<SourceMap> = Default::default();
            let fm = cm.new_source_file(FileName::Anon.into(), code.to_string());

            let lexer = Lexer::new(
                Syntax::Typescript(TsSyntax {
                    tsx: false,
                    decorators: true,
                    ..Default::default()
                }),
                Default::default(),
                (&*fm).into(),
                None,
            );

            let mut parser = Parser::new_from(lexer);
            let module = parser.parse_module().expect("Failed to parse");

            let ids = VarDeclWithTsDeclareCollector::collect(&module);
            let mut result: Vec<_> = ids.iter().map(|id| id.0.to_string()).collect();
            result.sort();
            result
        })
    }

    #[test]
    fn test_collect_declare_const() {
        let ids = parse_and_collect("declare const Foo: number;");
        assert_eq!(ids, vec!["Foo"]);
    }

    #[test]
    fn test_collect_declare_global() {
        let ids = parse_and_collect("declare global {}");
        assert_eq!(ids, vec!["global"]);
    }

    #[test]
    fn test_collect_declare_global_with_content() {
        let ids = parse_and_collect(
            r#"
            declare global {interface Window {foo: string;}}
            "#,
        );
        assert_eq!(ids, vec!["global"]);
    }

    #[test]
    fn test_collect_multiple_declares() {
        let ids = parse_and_collect(
            r#"
            declare const Foo: number;
            declare global {}
            declare const Bar: string;
            "#,
        );
        assert_eq!(ids, vec!["Bar", "Foo", "global"]);
    }

    #[test]
    fn test_no_collect_non_declare() {
        let ids = parse_and_collect("const Foo = 1;");
        assert!(ids.is_empty());
    }

    #[test]
    fn test_collect_declare_namespace() {
        // `declare namespace Foo {}` should also be collected
        let ids = parse_and_collect("declare namespace Foo {}");
        assert_eq!(ids, vec!["Foo"]);
    }
}